Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: storage: narrow down use of SingleDel to avoid anomalies #70123

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 13, 2021

Backport 1/1 commits from #69923 on behalf of @tbg.

/cc @cockroachdb/release


Fixes #69414.

Only use SingleDel if

  • the meta tracking allows it (i.e. the sole previous condition), and
  • epoch zero, and
  • no ignored txn seqno ranges.

These three together imply that the engine history of the metadata key
is a single Set, so we can safely use SingleDel.

Release justification: fix for a release blocker
Release note: None


Release justification:

Fixes #69414.

Only use SingleDel if

- the meta tracking allows it (i.e. the sole previous condition), and
- epoch zero, and
- no ignored txn seqno ranges.

These three together imply that the engine history of the metadata key
is a single `Set`, so we can safely use `SingleDel`.

Release justification: fix for a release blocker
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 13, 2021 15:12
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-69923 branch from d0969ba to 31e9e39 Compare September 13, 2021 15:12
@blathers-crl blathers-crl bot requested review from sumeerbhola and tbg September 13, 2021 15:12
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 13, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg
Copy link
Member

tbg commented Sep 13, 2021

cc @celiala we need this backport for the beta.

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @tbg)

@tbg tbg merged commit 38b1770 into release-21.2 Sep 14, 2021
@tbg tbg deleted the blathers/backport-release-21.2-69923 branch September 14, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants