[WIP] catalog: remove draining names #70058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This is too aggressive. We still need to support them in the mixed version state. Otherwise we can end up in cases where there's a namespace entry corresponding to a draining name that will never be cleaned up. |
|
I'm aware, this PR was put up simply to run the CI suite. |
added 3 commits
September 14, 2021 09:29
postamar
force-pushed
the
no-draining-names
branch
from
54dcaa3 to
e21b2f4
Compare
|
closed in favour of #70334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still a work in progress