-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: add passing tests for lib/pq and pgjdbc #69934
Conversation
@@ -38,7 +71,6 @@ var libPQBlocklist20_2 = blocklist{ | |||
"pq.TestCopyInTypes": "5807", | |||
"pq.TestCopyRespLoopConnectionError": "5807", | |||
"pq.TestEncodeAndParseTs": "41563", | |||
"pq.TestErrorDuringStartup": "41551", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intentional (does it close issues on 21_1?) that said, i guess at some stage we should cleanup all these older version blocklists because they're per branch now (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @RichardJCai)
pkg/cmd/roachtest/tests/libpq_blocklist.go, line 41 at r1 (raw file):
"pq.TestCopyRespLoopConnectionError": "5807", "pq.TestEncodeAndParseTs": "41563", "pq.TestErrorDuringStartup": "41551",
Same question as Oliver, is this intentional?
nope that was a mistake! |
Release justification: test only change Release note: None
4298f47
to
5f91349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @otan, @rafiss, and @RichardJCai)
tftr! bors r=arulajmani |
This PR was included in a batch that was canceled, it will be automatically retried |
Build succeeded: |
fixes #69527
fixes #69190
Release justification: test only change
Release note: None