Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add passing tests for lib/pq and pgjdbc #69934

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Sep 8, 2021

fixes #69527
fixes #69190

Release justification: test only change
Release note: None

@rafiss rafiss requested review from RichardJCai and a team September 8, 2021 18:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@@ -38,7 +71,6 @@ var libPQBlocklist20_2 = blocklist{
"pq.TestCopyInTypes": "5807",
"pq.TestCopyRespLoopConnectionError": "5807",
"pq.TestEncodeAndParseTs": "41563",
"pq.TestErrorDuringStartup": "41551",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional (does it close issues on 21_1?) that said, i guess at some stage we should cleanup all these older version blocklists because they're per branch now (?)

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @RichardJCai)


pkg/cmd/roachtest/tests/libpq_blocklist.go, line 41 at r1 (raw file):

	"pq.TestCopyRespLoopConnectionError":             "5807",
	"pq.TestEncodeAndParseTs":                        "41563",
	"pq.TestErrorDuringStartup":                      "41551",

Same question as Oliver, is this intentional?

@rafiss
Copy link
Collaborator Author

rafiss commented Sep 13, 2021

nope that was a mistake!

Release justification: test only change
Release note: None
@blathers-crl blathers-crl bot requested a review from otan September 13, 2021 15:21
Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan, @rafiss, and @RichardJCai)

@rafiss
Copy link
Collaborator Author

rafiss commented Sep 13, 2021

tftr!

bors r=arulajmani

@craig
Copy link
Contributor

craig bot commented Sep 13, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 13, 2021

Build succeeded:

@craig craig bot merged commit 386e099 into cockroachdb:master Sep 13, 2021
@rafiss rafiss deleted the orm-passing-tests branch September 13, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: pgjdbc failed roachtest: lib/pq failed
4 participants