importccl: add IMPORT INTO UDT support for default+computed columns #69779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
force-pushed
the
import-default-udt
branch
3 times, most recently
from
ace86cb to
9880bd8
Compare
|
The last commit is the one to be reviewed. I'm still figuring out how avro works with default columns, but apart from that test this should be ready for a review. |
adityamaru
force-pushed
the
import-default-udt
branch
from
9880bd8 to
e868e27
Compare
dt
approved these changes
Sep 7, 2021
adityamaru
force-pushed
the
import-default-udt
branch
3 times, most recently
from
f821ea0 to
05ff860
Compare
This change builds on the work in cockroachdb#69674 and uses the type descriptors stored on the import job during planning to construct a custom type resolver. This resolver is used when hydrating the types used by the table being imported into, and when processing default + computed columns. Informs: cockroachdb#61133 Release note (sql change): IMPORT INTO now supports UDT for default and computed columns. Release justification: fixes for high-priority or high-severity bugs in existing functionality Co-authored-by: Anne Zhu <[email protected]>
adityamaru
force-pushed
the
import-default-udt
branch
from
05ff860 to
5608424
Compare
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on the work in #69674 and uses the type
descriptors stored on the import job during planning to construct
a custom type resolver. This resolver is used when hydrating the
types used by the table being imported into, and when processing
default + computed columns.
Informs: #61133
Release note (sql change): IMPORT INTO now supports UDT for default
and computed columns.
Release justification: fixes for high-priority or high-severity bugs in existing functionality