build: increase pebble nightly metamorphic test runtime #69720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the runtime of the Pebble nightly metamorphic test run from 1h to 3h. More test time increases the chance of catching a test failure. See cockroachdb#69414. Release justification: non-production code change Release note: None
|
This change is |
nicktrav
commented
Sep 1, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jbowens and @sumeerbhola)
build/teamcity-nightly-pebble-metamorphic.sh, line 30 at r1 (raw file):
"TC_BUILD_BRANCH=$TC_BUILD_BRANCH" "PKG=internal/metamorphic" "STRESSFLAGS=-maxtime 3h -maxfails 1 -stderr -p 1"
Following on from internal conversation, running the tests longer has an associated cost.
Not sure if anyone needs to sign off on this? Can / should we test even longer?
jbowens
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the runtime of the Pebble nightly metamorphic test run from 1h
to 3h. More test time increases the chance of catching a test failure.
See #69414.
Release justification: non-production code change
Release note: None