sql/catalog/multiregion: move multiregion validation to its package #69608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajwerner
requested review from
ajstorm,
a team and
shermanCRL
and removed request for
a team
|
This change is |
otan
approved these changes
Aug 31, 2021
.github/CODEOWNERS
Outdated
| @@ -48,6 +48,7 @@ | |||
| /pkg/sql/tests/rsg_test.go @cockroachdb/sql-experience | |||
|
|
|||
| /pkg/sql/catalog/ @cockroachdb/sql-schema | |||
| /pkg/sql/catalog/multiregion @cockroachdb/sql-experience | |||
There was a problem hiding this comment.
make it/add @cockroachdb/multiregion :P
This code and these invariants are seen as the responsibility of the sql-experience team, so, let's move them to a package that that team owns. Release justification: Low risk code movement. Release note: None
ajwerner
force-pushed
the
ajwerner/move-some-multiregion-validation
branch
from
97ddadb to
e8e963b
Compare
|
TFTR! bors r=otan |
shermanCRL
requested review from
adityamaru
and removed request for
shermanCRL
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code and these invariants are seen as the responsibility of the
multiregion team, so, let's move them to a package that that team owns.
Release justification: Low risk code movement.
Release note: None