Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make unsafe-remove-dead-replicas work with encrypted stores #69566

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

sumeerbhola
Copy link
Collaborator

Release justification: Low-risk bug fix to existing functionality.
Release note: None

Release justification: Low-risk bug fix to existing functionality.
Release note: None
@sumeerbhola sumeerbhola requested review from a team as code owners August 30, 2021 12:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)

Copy link
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @sumeerbhola)

@sumeerbhola
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 30, 2021

Build succeeded:

@craig craig bot merged commit e946415 into cockroachdb:master Aug 30, 2021
@aayushshah15
Copy link
Contributor

Do we have any interest in backporting this to 21.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants