Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: remove non-deterministic test #69535

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Conversation

maryliag
Copy link
Contributor

A new test was added but it would fail depending on the
time it was executed. This commit remove this flaky test
so in a future PR we can add new set of tests that make
more sense to test this functionality.

Fixes #69533

Release justification: Category 3 bug fix
Release note: None

A new test was added but it would fail depending on the
time it was executed. This commit remove this flaky test
so in a future PR we can add new set of tests that make
more sense to test this functionality.

Fixes cockroachdb#69533

Release justification: Category 3 bug fix
Release note: None
@maryliag maryliag requested a review from a team August 28, 2021 17:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@Azhng Azhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@maryliag maryliag changed the title server: remove non-deterministic tes server: remove non-deterministic test Aug 28, 2021
@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 28, 2021

Build succeeded:

@craig craig bot merged commit 3d20259 into cockroachdb:master Aug 28, 2021
@maryliag maryliag deleted the flaky-test branch September 24, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: TestStatusAPICombinedStatements is flaky
3 participants