jobs, backupccl: DROP SCHEDULE clears DependentID and releases PTS

[adityamaru]

jobs, backupccl: DROP SCHEDULE clears DependentID and releases PTS
This change teaches DROP SCHEDULE to clear the dependent ID
linkage from the dependent schedule.

It also releases the protected timestamp (if any) on the schedule
being dropped. This pts would have been written if chaining of pts
was enabled.

Release note: None

backupccl: fix SHOW CREATE SCHEDULE options
In the previous commit DROP SCHEDULE wipes the dependent
ID linkage. SHOW CREATE SCHEDULE on an incremental schedule
whose dependent full schedule has been dropped will now
print a CREATE SCHEDULE statement with the full backup
recurrence cleared. This means that if the user were to copy
paste the command, we would choose a full backup recurrence
based on the incremental recurrence.

This commit also fixes the schedule options that are printed
as the output of SHOW CREATE SCHEDULE. Previously, these
would be printed as the string representations of the enum
values, but this was not round-trippable.

Informs: #69129

Release note: None

[cockroach-teamcity]

This change is 

[miretskiy]

Reviewed 4 of 5 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @adityamaru, @dt, and @miretskiy)

---

pkg/ccl/backupccl/schedule_exec.go, line 393 at r1 (raw file):

}

// OnDrop implements the ScheduledJobController interface.

perhaps quick description of what it does (drops dependent schedule, etc)...

---

pkg/jobs/scheduled_job_executor.go, line 68 at r1 (raw file):

	// SCHEDULE` query.
	OnDrop(ctx context.Context, ie sqlutil.InternalExecutor, ptsProvider protectedts.Provider,
		env scheduledjobs.JobSchedulerEnv, schedule *ScheduledJob, txn *kv.Txn) error

It would be nice if we didn't expose ptsProvider as a top level argument.
Either we can pass full sql.ExecutorConfig to this function, or, and I think that would be my preference,
introduce

type ScheduleControllerExecConfig struct {
   ....
}

Or even

type ScheduleControllerEnv interface {
   InternalExecutor()
   PTSProvider()
}

(and just wrap executor config with a struct implementing above small interface).

[adityamaru]

Unrelated bazel time out.

TFTR!

bors r=miretskiy

[adityamaru]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @dt and @miretskiy)

---

pkg/ccl/backupccl/schedule_exec.go, line 393 at r1 (raw file):

Previously, miretskiy (Yevgeniy Miretskiy) wrote…

perhaps quick description of what it does (drops dependent schedule, etc)...

Done.

---

pkg/jobs/scheduled_job_executor.go, line 68 at r1 (raw file):

Previously, miretskiy (Yevgeniy Miretskiy) wrote…

It would be nice if we didn't expose ptsProvider as a top level argument.
Either we can pass full sql.ExecutorConfig to this function, or, and I think that would be my preference,
introduce

type ScheduleControllerExecConfig struct {
   ....
}

Or even

type ScheduleControllerEnv interface {
   InternalExecutor()
   PTSProvider()
}

(and just wrap executor config with a struct implementing above small interface).

Done. ExecutorConfig is in SQL pkg which causes an import cycle in scheduledjobs, so I just stored what we need in the lightweight struct.

[craig]

Build succeeded:

• GitHub CI (Cockroach)