storageccl: remove non-ReturnSST ExportRequest #69044
Conversation
dt
requested review from
aliher1911,
a team and
nihalpednekar
and removed request for
a team
|
This change is |
dt
changed the title
There was a problem hiding this comment.
What happens during upgrades if caller is unaware? It would fail until it is upgraded and then it would not retry with ReturnSST = true?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nihalpednekar)
|
During upgrade we typically plan the sql procs that send export requests on the same nodes as the leaseholders so they send to themselves. Only if we somehow get a leaseholder move mid backup across versions so we expect a mismatch. In that case if they have set the old always proxy writes setting their old nodes will ask for ReturnSST and should be fine. If they haven’t, their backup might fail and they would need to enable that setting to try again (or finish rolling out the new binary) |
|
I just realized i never backported #66540. Hm. |
Release note: none.
|
Fixing a (potential) bug while I'm here and adding an extra check that the caller didn't ask for/expect the file to be encrypted, which is a potential if an older tenant pod asked mid-upgrade. Think I'll land this and get a 66540 backport going. |
|
TFTR! bors r+ |
|
Build succeeded: |
Release justification: bug fix in new functionality.
Release note: none.