Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: avoid NPE on cluster creation retries exceeded #68988

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

tbg
Copy link
Member

@tbg tbg commented Aug 16, 2021

When this branch was hit (as it was recently on AWS due to quota issues)
roachtest was giving up anyway, but it wasn't nice that it exploded prematurely
instead of shutting down in an orderly fashion.

Release note: None

@tbg tbg requested a review from a team as a code owner August 16, 2021 14:16
@tbg tbg requested review from otan and removed request for a team August 16, 2021 14:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg requested a review from stevendanna August 16, 2021 14:16
@tbg
Copy link
Member Author

tbg commented Aug 17, 2021

bors r=otan

@craig
Copy link
Contributor

craig bot commented Aug 17, 2021

Build succeeded:

@craig craig bot merged commit ecab37d into cockroachdb:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants