changefeedccl: detect sink URLs with no scheme #68978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a user provided a sink URL with no scheme (such as ` kafka%3A%2F%2Fnope%0A`), a changefeed job would be started. However, this changefeed job would be writing into a bufferSink. The bufferSink is used by core changefeeds. The user may have provided such a URL because of confusion over how to URL encode their sink URL. Now, they will receive an error such as ``` pq: no scheme found for sink URL "kafka%3A%2F%2Fnope%0A" ``` Release note (enterprise change): CHANGEFEED statements now error if the provided sink URL does not contain a scheme. Such URLs are typically a mistake and will result in non-functional changefeeds.
|
This change is |
HonoreDB
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
pkg/ccl/changefeedccl/sink.go, line 82 at r1 (raw file):
newSink := func() (Sink, error) { if feedCfg.SinkURI == "" {
Ah, that explains where this came from.
|
bors r=HonoreDB |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user provided a sink URL with no scheme (such as
kafka%3A%2F%2Fnope%0A), a changefeed job would be started. However,this changefeed job would be writing into a bufferSink. The
bufferSink is used by core changefeeds.
The user may have provided such a URL because of confusion over how to
URL encode their sink URL.
Now, they will receive an error such as
Release note (enterprise change): CHANGEFEED statements now error
if the provided sink URL does not contain a scheme. Such URLs are
typically a mistake and will result in non-functional changefeeds.