github: redirect KV code reviews to @cockroachdb/kv-prs #68903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
approved these changes
Aug 13, 2021
|
Thanks! bors r+ |
|
Build failed (retrying...): |
|
bors r- Broken tests |
|
Canceled. |
We try to use the @cockroachdb/kv alias for notifying the entire team on issues. There's no way to disable notifications for github's automatic codeowners driven review requests, and that tends to be a firehose, so lets use this sub-team alias instead. Release note: None
irfansharif
force-pushed
the
210813.kv-codeowners
branch
from
13506d2 to
d8d71d4
Compare
|
bors r+ |
|
Build succeeded: |
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Aug 17, 2021
Missed one in cockroachdb#68903. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Aug 17, 2021
68678: opt: don't use outer columns as implicit grouping columns r=DrewKimball a=DrewKimball Previously, the optbuilder logic would add any outer column that is referenced in a grouping context to the set of grouping columns. This is correct in some cases, because outer columns are effectively constant, and can just be removed by norm rules. However, it is incorrect in the case when there are no grouping columns, e.g. a `ScalarGroupBy`. In that case, the `ScalarGroupBy` would inadvertently be converted into a `GroupBy`. This patch modifies the optbuilder to simply ignore outer columns in a grouping context. Fixes #68290 Release note: None 68997: stats: use table descriptors instead of IDs r=postamar a=postamar Previously, the sql stats package inferred various properties about a table from its ID, like if it is a system or a virtual table. However the table descriptor is usually readily or easily available, providing much richer information about a table than its ID. In particular, this allows us to stop collecting stats for views. Release note (sql change): table statistics are no longer collected for views. 69024: colexec: fix bytes corruption for disk-spilled window functions r=DrewKimball a=DrewKimball This patch fixes the `Truncate` method for bytes columns so that it updates the offsets to be non-decreasing up to the new `maxSetLength`. This is necessary in the case when the new `maxSetLength` is greater than the old one. This can happen when a window function has a bytes output column and the `SpillingQueue` that buffers input batches spills to disk. If a batch has trailing nulls up to the last processed index, and it is immediately enqueued to disk, `SpillingQueue` does not call `SetLength` on the batch, so the offsets still need to be updated (in this case by `Truncate`). Fixes #60824 Release note: None 69039: github: route pkg/migration PRs to kv-prs sub-team r=irfansharif a=irfansharif Missed one in #68903. Release note: None Co-authored-by: Drew Kimball <[email protected]> Co-authored-by: Marius Posta <[email protected]> Co-authored-by: irfan sharif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to use the @cockroachdb/kv alias for notifying the entire team on
issues. There's no way to disable notifications for github's automatic
codeowners driven review requests, and that tends to be a firehose, so
lets use this sub-team alias instead.
Release note: None