utilccl: add ErrBreakerOpen to bulk retryable error #68899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#68787 we saw a backup job failing on retry because of attempting to plan a flow on a node that has been shutdown. This should not usually happen since everytime we plan the flow we fetch the nodes that can participate in the distsql flow. In case we do encounter a `breaker open` error we can retry hoping that the next time the flow is planned it doesn't attempt to dial the dead node. Release note: None
|
This change is |
pbardea
approved these changes
Aug 16, 2021
|
TFTR! bors r=pbardea |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #68787
we saw a backup job failing on retry because of attempting
to plan a flow on a node that has been shutdown. This should
not usually happen since everytime we plan the flow we fetch
the nodes that can participate in the distsql flow.
In case we do encounter a
breaker openerror we can retryhoping that the next time the flow is planned it doesn't
attempt to dial the dead node.
Release note: None