Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support regrole OID alias type #68877

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

nvanbenschoten
Copy link
Member

@nvanbenschoten nvanbenschoten commented Aug 13, 2021

regrole was added in Postgres 9.5 alongside regnamespace as an
additional object identifier alias type. As the name suggests, it
references the pg_catalog.pg_authid table (not pg_roles, which is
a view over pg_authid). This commit adds support for this type,
along with its corresponding input and output routines.

This is necessary but not sufficient to support PostgREST.

Release note (sql change): The regrole OID alias type is now supported,
which is a Postgres-compatible object identifier alias that references
the pg_catalog.pg_authid table.

@nvanbenschoten nvanbenschoten requested a review from rafiss August 13, 2021 04:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@awoods187 awoods187 mentioned this pull request Aug 16, 2021
22 tasks
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too! could you add a release note in the commit message?

regrole was added in Postgres 9.5 alongside regnamespace as an
additional object identifier alias type. As the name suggests, it
references the pg_catalog.pg_authid table (not pg_roles, which is
a view over pg_authid). This commit adds support for this type,
along with its corresponding input and output routines.

This is necessary but not sufficient to support PostgREST.

Release note (sql change): The regrole OID alias type is now supported,
which is a Postgres-compatible object identifier alias that references
the pg_catalog.pg_authid table.
@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/regrole branch from 971364b to 035a781 Compare August 17, 2021 22:21
@nvanbenschoten
Copy link
Member Author

could you add a release note in the commit message?

Done.

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 18, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 18, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 18, 2021

Build succeeded:

@craig craig bot merged commit 69d0afb into cockroachdb:master Aug 18, 2021
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/regrole branch August 28, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants