Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: generate docs/generated/redact_safe.md in dev #68836

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

rickystewart
Copy link
Collaborator

This file can't properly be bazelfied because generating it requires
access to the entire source tree, which we can't easily pass into the
Bazel sandbox. Instead it gets special non-Bazel support in dev and a
special validation in CI.

Closes #67923

Release note: None

@rickystewart rickystewart requested a review from rail August 12, 2021 22:43
@rickystewart rickystewart requested a review from a team as a code owner August 12, 2021 22:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Aug 13, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 13, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 14, 2021

Merge conflict.

This file can't properly be bazelfied because generating it requires
access to the entire source tree, which we can't easily pass into the
Bazel sandbox. Instead it gets special non-Bazel support in `dev` and a
special validation in CI.

Closes cockroachdb#67923

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Aug 16, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 16, 2021

Build succeeded:

@craig craig bot merged commit 66c60f2 into cockroachdb:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel: bazelize docs/generated/redact_safe.md generation
3 participants