sql: fix sql input to security.SQLUsername issue #68830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
e-mbrown
force-pushed
the
eb/sqlusername
branch
3 times, most recently
from
0be26a4 to
1e44f3a
Compare
e-mbrown
force-pushed
the
eb/sqlusername
branch
from
1e44f3a to
bcb3b18
Compare
RichardJCai
approved these changes
Aug 16, 2021
RichardJCai
reviewed
Aug 16, 2021
| @@ -8869,10 +8858,10 @@ multiple_set_clause: | |||
| // TO {<name> | CURRENT_USER | SESSION_USER} | |||
| // %SeeAlso: DROP OWNED BY | |||
| reassign_owned_by_stmt: | |||
| REASSIGN OWNED BY role_spec_list TO role_spec | |||
| REASSIGN OWNED BY name_list TO role_spec | |||
There was a problem hiding this comment.
Can you look into normalizing role_spec correctly as well?
See:
#55396
and:
https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/parser/sql.y#L1319
https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/parser/sql.y#L2478
Can be a separate PR
The statements drop owned by and reassigned owned were case-sensitive because they relied on role_spec_list which wasnt correctly generating security.SQLusername. With this change the two statement use NameLists that are then converted into security.SQLusernames. role_spec_list has been removed from the parser because it is no longer being used. Release note: None
e-mbrown
force-pushed
the
eb/sqlusername
branch
from
bcb3b18 to
c3f09f1
Compare
|
bors r=RichardJCai |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #67818
The statements
drop owned byandreassigned owned bywere case-sensitive because they relied onrole_spec_listwhich wasn't correctly generatingsecurity.SQLusername. With this change the two statement useNameListsthat are then converted intosecurity.SQLusernames.role_spec_listhas been removed from the parser because it is no longer being used.Release note: None