randgen: generate random expression indexes #68812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
|
This commit refactors the code that generates random computed columns so that the logic for generating random expressions can be used in a future commit to generate random expression indexes. Release note: None
The `randgen` package now generates schemas with random expression indexes. This allows for random testing of expression indexes in `sqlsmith` and ternary logic partitioning (TLP). Fixes cockroachdb#68174 Release note: None
mgartner
force-pushed
the
randgen-expr-idx
branch
from
b486143 to
4fd177c
Compare
michae2
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Reviewed 16 of 16 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randgen: refactor random expression generation
This commit refactors the code that generates random computed columns so
that the logic for generating random expressions can be used in a future
commit to generate random expression indexes.
Release note: None
randgen: generate random expression indexes
The
randgenpackage now generates schemas with random expressionindexes. This allows for random testing of expression indexes in
sqlsmithand ternary logic partitioning (TLP).Fixes #68174
Release note: None