sql: preserve point lookups in PartitionSpans #68809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, `PartitionSpans` function would convert the point lookups into a single key spans. This is suboptimal since GetRequests are better, so this commit fixes that oversight. Release note: None
yuzefovich
force-pushed
the
point-lookups
branch
from
2947f74 to
1975fc7
Compare
rytaft
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Is there already a test somewhere that we actually use a GetRequest if the span has no end key?
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
|
GetRequests usage was added by Jordan recently in #61583, and that PR did add the checks to make sure that Get requests are actually used. TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
PartitionSpansfunction would convert the point lookupsinto a single key spans. This is suboptimal since GetRequests are
better, so this commit fixes that oversight.
Release note: None