sql: fix COPY CSV so it handles multiple records at a time #68573
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken since the golang csv reader reads the entire input all at once, so the underlying buffer is consumed. This caused the loop that reads each record to terminate early. Release note (bug fix): Fixed the COPY CSV command so that it handles multiple records separated by newline characters.
|
This change is |
otan
approved these changes
Aug 8, 2021
|
tftr! bors r=otan |
|
Build failed (retrying...): |
|
bors r=otan |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #68484
This was broken since the golang csv reader reads the entire input all
at once, so the underlying buffer is consumed. This caused the loop that
reads each record to terminate early.
Release note (bug fix): Fixed the COPY CSV command so that it handles
multiple records separated by newline characters.