Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: add option to display descriptor ids to SHOW BACKUP #68540

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Aug 6, 2021

Previously there weren't any descriptor ID information displayed by SHOW BACKUP. These IDs provide
useful information during triage and general debugging. To address this, a WITH option debug_ids
was added to populate additional columns in SHOW BACKUP with descriptor IDS of all objects along
with the IDs of its database and parent schema.

Release note (enterprise change): Descriptor IDs of every object are now visible in SHOW BACKUP,
along with the descriptor IDs of the object's database and parent schema. SHOW BACKUP will display
these IDs if the WITH debug_ids option is specified.

@rhu713 rhu713 requested review from a team and nihalpednekar and removed request for a team August 6, 2021 16:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713 rhu713 requested review from dt and removed request for nihalpednekar August 6, 2021 16:06
Previously there weren't any descriptor ID information displayed by
SHOW BACKUP. These IDs provide useful information during triage and
general debugging. To address this, a WITH option debug_ids was added
to populate additional columns in SHOW BACKUP with descriptor IDS of
all objects along with the IDs of its database and parent schema.

Release note (enterprise change): Descriptor IDs of every object are now visible in SHOW BACKUP,
along with the descriptor IDs of the object's database and parent schema. SHOW BACKUP will display
these IDs if the `WITH debug_ids` option is specified.
@rhu713
Copy link
Contributor Author

rhu713 commented Aug 6, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 6, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 6, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 6, 2021

Build failed (retrying...):

craig bot pushed a commit that referenced this pull request Aug 6, 2021
68540: backupccl: add option to display descriptor ids to SHOW BACKUP r=rhu713 a=rhu713

Previously there weren't any descriptor ID information displayed by SHOW BACKUP. These IDs provide
useful information during triage and general debugging. To address this, a WITH option debug_ids
was added to populate additional columns in SHOW BACKUP with descriptor IDS of all objects along
with the IDs of its database and parent schema.

Release note (enterprise change): Descriptor IDs of every object are now visible in SHOW BACKUP,
along with the descriptor IDs of the object's database and parent schema. SHOW BACKUP will display
these IDs if the `WITH debug_ids` option is specified.

Co-authored-by: Rui Hu <[email protected]>
@craig
Copy link
Contributor

craig bot commented Aug 7, 2021

Build failed:

@rhu713
Copy link
Contributor Author

rhu713 commented Aug 9, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 9, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants