Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/log,docs/generated: update crdb-v2 example formatting #68506

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

taroface
Copy link
Collaborator

@taroface taroface commented Aug 5, 2021

The crdb-v2 log examples in the autogen docs were not appearing correctly when embedded on the public docs page. As a workaround, that doc is currently using a manually altered copy of the logformats.md doc. This change should fix the formatting issues and enable us to embed the generated doc (see: cockroachdb/docs#11018).

Release note: none

@taroface taroface requested a review from knz August 5, 2021 20:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented Aug 5, 2021

@cameronnunez can you please review this thanks

Copy link
Contributor

@cameronnunez cameronnunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@taroface
Copy link
Collaborator Author

taroface commented Aug 9, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 9, 2021

Build succeeded:

@craig craig bot merged commit ea1ff1e into cockroachdb:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants