Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add VIRTUAL syntax to help #68443

Merged
merged 1 commit into from
Aug 5, 2021
Merged

parser: add VIRTUAL syntax to help #68443

merged 1 commit into from
Aug 5, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 4, 2021

Release note: None

@rafiss rafiss requested review from RaduBerinde and a team August 4, 2021 20:01
@cockroach-teamcity
Copy link
Member

This change is Reviewable

RaduBerinde
RaduBerinde approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 5, 2021

tftr!

bors r=RaduBerinde

@craig
Copy link
Contributor

craig bot commented Aug 5, 2021

Build failed:

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 5, 2021

bors r=RaduBerinde

@craig
Copy link
Contributor

craig bot commented Aug 5, 2021

Build succeeded:

@craig craig bot merged commit 78a788f into cockroachdb:master Aug 5, 2021
@rafiss rafiss deleted the add-virtual-to-syntax-help branch August 10, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaduBerinde RaduBerinde RaduBerinde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafiss @cockroach-teamcity @RaduBerinde