sql/tenant: remove idle detection and exit flag #68431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
darinpp
force-pushed
the
remove-idle-exit
branch
2 times, most recently
from
7e9923b to
79906e2
Compare
darinpp
changed the title
We previoulsy had a flag `--idle-exit-after` that was used to monitor the active SQL connections and terminate the server if there are no more clients. We don't need that functionality anymore so this PR removes it. It also fixes the issues with the related flaky tests. Fixes cockroachdb#66767 Release note: None
darinpp
force-pushed
the
remove-idle-exit
branch
from
79906e2 to
7867b59
Compare
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previoulsy had a flag
--idle-exit-afterthat was used to monitor theactive SQL connections and terminate the server if there are no more
clients. We don't need that functionality anymore so this PR removes it.
It also fixes the issues with the related flaky tests.
Fixes #66767
Release note: None