Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix show syntax re-parse issue #68424

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

e-mbrown
Copy link
Contributor

@e-mbrown e-mbrown commented Aug 4, 2021

Related to: #60722

Show test were having re-parse issues due to a type error. This change replaces the underscore with a string value.

Release note: None

@e-mbrown e-mbrown requested a review from rafiss August 4, 2021 16:13
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from a team August 4, 2021 17:38
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! could you change the message to

The SHOW SYNTAX statement had re-parse issues because it requires
a string constant. This change replaces the underscore with a string
value when using the `FmtHideConstants` flag.

The SHOW SYNTAX statement had re-parse issues because it requires
a string constant. This change replaces the underscore with a string
value when using the `FmtHideConstants` flag.

Release note: None
@e-mbrown
Copy link
Contributor Author

e-mbrown commented Aug 4, 2021

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Aug 4, 2021

Build succeeded:

@craig craig bot merged commit 0592999 into cockroachdb:master Aug 4, 2021
@e-mbrown e-mbrown deleted the eb/show_fix branch September 7, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants