sql: fix literal reparse issue with timestamps #68336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
e-mbrown
force-pushed
the
eb/timestamp_literals
branch
3 times, most recently
from
78bd4cc to
39c91eb
Compare
rafiss
requested changes
Aug 2, 2021
| @@ -1626,7 +1626,11 @@ func (node *CastExpr) Format(ctx *FmtCtx) { | |||
| if _, ok := node.Expr.(*StrVal); ok { | |||
| ctx.FormatTypeReference(node.Type) | |||
| ctx.WriteByte(' ') | |||
| ctx.FormatNode(node.Expr) | |||
| if ctx.HasFlags(FmtHideConstants) { | |||
There was a problem hiding this comment.
i think this might need an explanatory comment.
could you add a comment saying that "we need to replace this with a quoted string constant because the grammar requires a string constant rather than an expression for this form of casting in the typed_literal rule"
cockroach/pkg/sql/parser/sql.y
Line 11444 in 6eafde9
There were reparse issues in multiple test when timestamps were replaced with underscores. Making the underscore characters strings solved the issue. Release note: None
e-mbrown
force-pushed
the
eb/timestamp_literals
branch
from
39c91eb to
86701b2
Compare
rafiss
approved these changes
Aug 3, 2021
|
bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #60722
There were reparse issues in multiple test when timestamps
were replaced with underscores. Making the underscore characters
strings solved the issue.
Release note: None