colexec: fix LIKE operators when patterns have escape characters #68289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (bug fix): Previously, CockroachDB could incorrectly evaluate LIKE expressions when the pattern contained the escape characters `\` if the expressions were executed via the vectorized engine.
Whenever we're planning a projection expression, we have 3 cases: the left is constant, the right is constants, and neither are constants. For the second case we have some optimized operators. Previously, those operators weren't exercised via the TestEval/vectorized because in the eval tests the left side is constant. This commit switches the planning to force planning of those optimized operators. This shouldn't really have an effect on planning of actual queries. This was prompted by the bug in LIKE operators that is fixed in the previous commit. Had we forced the planning for our eval tests, we would have caught it earlier. This also revealed an incompatibility for our IN operator implementation when the right side is an empty tuple which this commit also fixes. However, I don't think this scenario can be hit in production because the optimizer folds such an expression into correct `false`. Thus, there is no release note. Release note: None
|
This change is |
mgartner
reviewed
Aug 2, 2021
There was a problem hiding this comment.
Nice! Good idea to fix upTestEval/vectorized.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
mgartner
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
Should this be backported to 20.2 and 21.1? |
|
Yeah, I think we should backport to 20.2 and 21.1 but only the first commit (that's why I didn't put labels on the PR and will do the backport manually). TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
68289: colexec: fix LIKE operators when patterns have escape characters r=yuzefovich a=yuzefovich **colexec: fix LIKE operators when patterns have escape characters** Fixes: #68040. Release note (bug fix): Previously, CockroachDB could incorrectly evaluate LIKE expressions when the pattern contained the escape characters `\` if the expressions were executed via the vectorized engine. **colbuilder: force planning of optimized projection operators** Whenever we're planning a projection expression, we have 3 cases: the left is constant, the right is constants, and neither are constants. For the second case we have some optimized operators. Previously, those operators weren't exercised via the TestEval/vectorized because in the eval tests the left side is constant. This commit switches the planning to force planning of those optimized operators. This shouldn't really have an effect on planning of actual queries. This was prompted by the bug in LIKE operators that is fixed in the previous commit. Had we forced the planning for our eval tests, we would have caught it earlier. This also revealed an incompatibility for our IN operator implementation when the right side is an empty tuple which this commit also fixes. However, I don't think this scenario can be hit in production because the optimizer folds such an expression into correct `false`. Thus, there is no release note. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
|
Build failed: |
|
I wanted to point out that there are other unsolved problems with the |
|
#44123 is a different beast - there, the problem seems to be during constraint generation in the optimizer. Seems like an unrelated flake. bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colexec: fix LIKE operators when patterns have escape characters
Fixes: #68040.
Release note (bug fix): Previously, CockroachDB could incorrectly
evaluate LIKE expressions when the pattern contained the escape
characters
\if the expressions were executed via the vectorizedengine.
colbuilder: force planning of optimized projection operators
Whenever we're planning a projection expression, we have 3 cases: the
left is constant, the right is constants, and neither are constants. For
the second case we have some optimized operators. Previously, those
operators weren't exercised via the TestEval/vectorized because in the
eval tests the left side is constant. This commit switches the planning
to force planning of those optimized operators. This shouldn't really
have an effect on planning of actual queries.
This was prompted by the bug in LIKE operators that is fixed in the
previous commit. Had we forced the planning for our eval tests, we would
have caught it earlier.
This also revealed an incompatibility for our IN operator implementation when
the right side is an empty tuple which this commit also fixes. However,
I don't think this scenario can be hit in production because the
optimizer folds such an expression into correct
false. Thus, there isno release note.
Release note: None