importccl: persist bulk op summary during execution #68218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pbardea
force-pushed
the
persist-res
branch
2 times, most recently
from
4702d7d to
ef70f3e
Compare
pbardea
force-pushed
the
persist-res
branch
6 times, most recently
from
edcf302 to
009b1a7
Compare
pbardea
requested review from
a team,
adityamaru and
dt
and removed request for
a team
|
@dt @adityamaru just a friendly ping, wondering if you can take a look this week, since this is blocking #67106 |
dt
approved these changes
Aug 17, 2021
pbardea
force-pushed
the
persist-res
branch
3 times, most recently
from
36a56e1 to
b6b7469
Compare
|
@pbardea thanks again for working on this, I really appreciate it! 🙂 |
|
Hoping to get this merged this aft! Fighting rebases and flakes, but I'm hoping this next push should do the trick. |
pbardea
force-pushed
the
persist-res
branch
4 times, most recently
from
4562d36 to
a3463cc
Compare
Release note (bug fix): Fix a bug where IMPORT internal retries (ie due to node failures) may not pick up latest progress updates.
pbardea
force-pushed
the
persist-res
branch
2 times, most recently
from
65684a8 to
305ec67
Compare
Release note (bug fix): Fix a bug where the summary displayed after an IMPORT command would sometimes be inaccurate due to retries. Release justification: Bug fix. Fix a bug where the summary displayed after an IMPORT command would sometimes be inaccurate due to retries.
|
There seems to be an issue with running the bazel import tests under race on master. Going to merge this as is and file an issue for that separately. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67987.
Fixes #67987.
Release note (bug fix): Fix a bug where the summary displayed after an
IMPORT command would sometimes be inaccurate due to retries.
Release justification: Bug fix. Fix a bug where the summary displayed after an
IMPORT command would sometimes be inaccurate due to retries.