sql: re-enable test TestImportPgDumpSchemas/inject-error-ensure-cleanup #68110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: cockroachdb#65878 Previously, this test was disable because it was acting flaky and failing in a fairly consistent manner. This was inadequate because the flaky failures have disappeared. To address this, this patch re-enables the test since we can't reproduce the failure after multiple attempts. Release note: None
fqazi
requested review from
a team and
nihalpednekar
and removed request for
a team
|
This change is |
postamar
approved these changes
Jul 28, 2021
|
bors r=postamar |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #65878
Previously, this test was disable because it was acting flaky
and failing in a fairly consistent manner. This was inadequate
because the flaky failures have disappeared. To address this, this
patch re-enables the test since we can't reproduce the failure
after multiple attempts.
Release note: None