sql: removed pg_stat exclusion for pg_catalog #67821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
Previously, we excluded pg_stat* tables from difftool This was inadequate because we were unable to add missing empty tables To address this, this patch removes the exclusion Release note: None
mnovelodou
force-pushed
the
remove-pg-stat-filter
branch
from
92ef190 to
156e514
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
RichardJCai
approved these changes
Jul 21, 2021
craig bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
67625: sql: GRANT/REVOKE treat names case insensitively r=RichardJCai a=rafiss fixes #65556 Release note (bug fix): Previously the GRANT and REVOKE commands would incorrectly handle role names. CockroachDB treats role names as case insensitive, but these commands were incorrectly handling the names. Now, GRANT and REVOKE normalize the names and are case-insensitive. 67821: sql: removed pg_stat exclusion for pg_catalog r=rafiss a=mnovelodou Previously, we excluded pg_stat* tables from difftool This was inadequate because we were unable to add missing empty tables To address this, this patch removes the exclusion Release note: None Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: MiguelNovelo <[email protected]>
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we excluded pg_stat* tables from difftool
This was inadequate because we were unable to add missing empty tables
To address this, this patch removes the exclusion
Release note: None