sql: copy hidden columns in CREATE TABLE LIKE #67799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
commented
Jul 20, 2021
| @@ -340,13 +341,28 @@ SHOW CREATE TABLE like_hash | |||
| ---- | |||
| like_hash CREATE TABLE public.like_hash ( | |||
| a INT8 NULL, | |||
| crdb_internal_a_shard_4 INT4 NOT VISIBLE NOT NULL AS (mod(fnv32(COALESCE(CAST(a AS STRING), '':::STRING)), 4:::INT8)) STORED, | |||
There was a problem hiding this comment.
so this is because INCLUDING DEFAULTS isn't in there, wonder if that's passable.
otan
force-pushed
the
like_fix
branch
2 times, most recently
from
be98153 to
d4fec08
Compare
Also contains logic that restore DEFAULTs for primary key being rowid, crdb_internal_region and hash sharded indexes. Release note (sql change): CREATE TABLE LIKE now copies hidden columns over.
|
bors r=rafiss |
|
Build succeeded: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #67196
Release note (sql change): CREATE TABLE LIKE now copies hidden columns
over.