Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update go to 1.16.6 #67594

Merged
merged 1 commit into from
Jul 14, 2021
Merged

build: update go to 1.16.6 #67594

merged 1 commit into from
Jul 14, 2021

Conversation

rail
Copy link
Member

@rail rail commented Jul 14, 2021 •
edited
Loading

  • Adjust the Pebble tests to run in new version.
  • Adjust version in Docker image (source).
  • Adjust version in the TeamCity agent image (setup script)
  • Rebuild and push the Docker image (following Basic Process)
  • Bump the version in WORKSPACE under go_register_toolchains. You may need to bump rules_go.
  • Bump the version in builder.sh accordingly (source).
  • Bump the version in go-version-check.sh (source), unless bumping to a new patch release.
  • Bump the go version in go.mod. You may also need to rerun make vendor_rebuild if vendoring has changed.
  • Bump the default installed version of Go in bootstrap-debian.sh (source).
  • Replace other mentions of the older version of go (grep for golang:<old_version> and go<old_version>).
  • Update the builder.dockerImage parameter in the TeamCity Cockroach and Internal projects.
  • Ask the Developer Infrastructure team to deploy new TeamCity agent images according to packer/README.md

Release note: None

@rail rail requested a review from a team as a code owner July 14, 2021 12:46
@rail rail self-assigned this Jul 14, 2021
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail
build: update go to 1.16.6
568629a 
* [ ] Adjust the Pebble tests to run in new version.
* [x] Adjust version in Docker image ([source](./builder/Dockerfile)).
* [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh))
* [x] Rebuild and push the Docker image (following [Basic Process](#basic-process))
* [x] Bump the version in `WORKSPACE` under `go_register_toolchains`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases).
* [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)).
* [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release.
* [x] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed.
* [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)).
* [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`).
* [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects.
* [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md)

Release note: None
@rail
Copy link
Member Author

rail commented Jul 14, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 14, 2021

Build succeeded:

@craig craig bot merged commit eef3cef into cockroachdb:master Jul 14, 2021
jbowens
jbowens reviewed Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

build/go-version-check.sh, line 10 at r1 (raw file):

required_version_major=1
minimum_version_minor=16
minimum_version_16_patch=6

does this need to happen on patch releases too? It prevents building on the previous patch releases without setting the IGNORE_GOVERS env var, which is a little annoying when go 1.16.5 is still the stable version of the homebrew formula: https://formulae.brew.sh/formula/go

@rail
Copy link
Member Author

rail commented Jul 14, 2021

does this need to happen on patch releases too? It prevents building on the previous patch releases without setting the IGNORE_GOVERS env var, which is a little annoying when go 1.16.5 is still the stable version of the homebrew formula: https://formulae.brew.sh/formula/go

I have no strong opinion about this TBH. Maybe it's just safer to have at least the same version of go that we use in CI.

jbowens
jbowens reviewed Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the above checklist indicates it shouldn't happen in patch releases:

Bump the version in go-version-check.sh (source), unless bumping to a new patch release

I think we should either not bump in go-version-check.sh on a patch release or wait to bump the version until at least the new go version is available via Homebrew.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

rail added a commit to rail/cockroach that referenced this pull request Jul 14, 2021
@rail
build: don't require latest go for local builds
d10530f 
In cockroachdb#67594 we switched to go 1.16.5, but it's not available via brew yet.
Because we tend to use the brew version to build locally, it would be
better to downgrade the requirements.

Release note: None
@rail rail mentioned this pull request Jul 14, 2021
Merged
@rail
Copy link
Member Author

rail commented Jul 14, 2021

I created #67620

craig bot pushed a commit that referenced this pull request Jul 14, 2021
@mgartner @rail
Merge #67522 #67608 #67620
5cee9d0 
67522: memsize: consolidate memory size constants r=mgartner a=mgartner

Constants that describe the in-memory size of data types have been
consolidated into a new package.

Release note: None

67608: build: update TeamCity secondary go to 1.15.14 r=rail a=rail

This updates the TeamCity agent go version to 1.15.14

Release note: None

67620: build: don't require latest go for local builds r=rail a=rail

In #67594 we switched to go 1.16.5, but it's not available via brew yet.
Because we tend to use the brew version to build locally, it would be
better to downgrade the requirements.

Release note: None

Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Rail Aliiev <[email protected]>
pawalt pushed a commit to pawalt/cockroach that referenced this pull request Jul 22, 2021
@rail @pawalt
build: don't require latest go for local builds
97562d6 
In cockroachdb#67594 we switched to go 1.16.5, but it's not available via brew yet.
Because we tend to use the brew version to build locally, it would be
better to downgrade the requirements.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbowens jbowens jbowens left review comments

@jlinder jlinder jlinder approved these changes

Assignees

@rail rail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rail @cockroach-teamcity @jlinder @jbowens