dev: infer and pass in an appropriate dev config to bazel invocations
#67540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Passing `--config=dev` for `dev` builds is a good choice, and `--config=devdarwinx86_64` is required for most dev builds on macOS machines. Automatically pass that flag unless the user requests not to. Release note: None
rail
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Reviewed 10 of 11 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
|
bors r=rail |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
--config=devfordevbuilds is a good choice, and--config=devdarwinx86_64is required for most dev builds on macOSmachines. Automatically pass that flag unless the user requests not to.
Release note: None