Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlsmith: make TLP predicates immutable #67194

Merged
merged 1 commit into from
Jul 6, 2021
Merged

sqlsmith: make TLP predicates immutable #67194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/internal/sqlsmith/tlp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ import (
// If the resulting counts of the two queries are not equal, there is a logical
// bug.
func (s *Smither) GenerateTLP() (unpartitioned, partitioned string) {
// Set disableImpureFns to true so that generated predicates are immutable.
originalDisableImpureFns := s.disableImpureFns
s.disableImpureFns = true
defer func() {
s.disableImpureFns = originalDisableImpureFns
}()

f := tree.NewFmtCtx(tree.FmtParsable)

table, _, _, cols, ok := s.getSchemaTable()
Expand Down