Update Kubernetes Manifests to comment out liveness probe

[keith-mcclellan]

Liveness probe can cause kubernetes to reboot nodes when the database is busy but functioning properly, so we are commenting out that probe.

[cockroach-teamcity]

All committers have signed the CLA.

[cockroach-teamcity]

This change is 

[taroface]

Just a phrasing suggestion!

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @chrisseto and @keith-mcclellan)

---

cloud/kubernetes/cockroachdb-statefulset.yaml, line 118 at r1 (raw file):

        - containerPort: 8080
          name: http
# We recommend that users don't configure liveness probes for production environments as it can impact availability of production databases.

I suggest this wording in all the manifests:

We recommend that you do not configure a liveness probe on a production environment, as this can impact the availability of production databases.

Do we want to add something like "A liveness probe can be used to verify the health of a test deployment." (if that is true)

I also suggest indenting this at the same level as livenessProbe to be consistent with the other comments.

[keith-mcclellan]

Just a phrasing suggestion!

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @chrisseto and @keith-mcclellan)

cloud/kubernetes/cockroachdb-statefulset.yaml, line 118 at r1 (raw file):

        - containerPort: 8080
          name: http
# We recommend that users don't configure liveness probes for production environments as it can impact availability of production databases.

I suggest this wording in all the manifests:

We recommend that you do not configure a liveness probe on a production environment, as this can impact the availability of production databases.

Do we want to add something like "A liveness probe can be used to verify the health of a test deployment." (if that is true)

I also suggest indenting this at the same level as livenessProbe to be consistent with the other comments.

Happy to change the wording. The second one isn't really true - liveness probes are good for "quiet" environments but noisy ones they're bad. This is something we'd probably want to expound on in the docs rather than a yaml comment. What do you think @taroface ?

[taroface]

Sounds good. I'll create a separate ticket to document the use of livenessProbe in e.g. the K8s monitoring doc.

[keith-mcclellan]

bors r+

[craig]

🔒 Permission denied

Existing reviewers: click here to make keith-mcclellan a reviewer

[taroface]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)