Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump cockroachdb/redact #67064

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

knz
Copy link
Contributor

@knz knz commented Jun 30, 2021

Fixes #64158

This introduces smart auto-formatting of structs and arrays
in redaction contexts.

This is a simplified version of #66880 to avoid the bazel brokenness.

@knz knz requested a review from tbg June 30, 2021 11:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz mentioned this pull request Jun 30, 2021
@knz knz force-pushed the 20210630-redact branch from b35467a to aa59d29 Compare June 30, 2021 16:33
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI needs some attention still.

@knz
Copy link
Contributor Author

knz commented Jul 1, 2021

oh my, the CI is even telling us there was an API regression (missing String method). I'll look at it now.

Release note: None
@knz knz force-pushed the 20210630-redact branch from aa59d29 to 557dc44 Compare July 1, 2021 14:39
@knz
Copy link
Contributor Author

knz commented Jul 1, 2021

fixed in cockroachdb/redact#24. Rebasing

@knz
Copy link
Contributor Author

knz commented Jul 1, 2021

ok this is flying now

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Jul 1, 2021

Build succeeded:

@craig craig bot merged commit c452a0c into cockroachdb:master Jul 1, 2021
@knz knz deleted the 20210630-redact branch July 12, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log: %s semantics different from stdlib for nil pointers
3 participants