Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: add toolchain for cross-compiling to linux on aarch64 #67039

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

rickystewart
Copy link
Collaborator

This is just another crosstool-ng toolchain, so we use all the
pre-existing stuff added in b782105.

Release note: None

@rickystewart rickystewart requested a review from rail June 29, 2021 21:42
@rickystewart rickystewart requested a review from a team as a code owner June 29, 2021 21:42
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart
Copy link
Collaborator Author

Part of #67037

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)


.bazelrc, line 26 at r1 (raw file):

build:crossmacos --crosstool_top=@toolchain_cross_x86_64-apple-darwin19//:suite
build:crosslinuxarm --platforms=//build/toolchains:cross_linux_arm
build:crosslinuxarm --crosstool_top=@toolchain_cross_aarch64-unknown-linux-gnu//:suite

A nit. Add a line return.

This is just another `crosstool-ng` toolchain, so we use all the
pre-existing stuff added in b782105.

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Jun 30, 2021

Build succeeded:

@craig craig bot merged commit 2f41ff5 into cockroachdb:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants