Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: surface the transaction restarts chart #66973

Merged
merged 1 commit into from
Jun 28, 2021
Merged

ui: surface the transaction restarts chart #66973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/ui/src/util/docs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ export const statementsSql = docsURL(
export const statementsRetries = docsURL(
"transactions.html#transaction-retries",
);
export const transactionRetryErrorReference = docsURL(
"transaction-retry-error-reference.html",
);
export const statementsTimeInterval = docsURL(
"admin-ui-statements-page.html#time-interval",
);
Expand Down
45 changes: 0 additions & 45 deletions pkg/ui/src/views/cluster/containers/nodeGraphs/dashboards/distributed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,51 +86,6 @@ export default function (props: GraphDashboardProps) {
</Axis>
</LineGraph>,

<LineGraph title="KV Transaction Restarts" sources={nodeSources}>
<Axis label="restarts">
<Metric
name="cr.node.txn.restarts.writetooold"
title="Write Too Old"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.writetoooldmulti"
title="Write Too Old (multiple)"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.serializable"
title="Forwarded Timestamp (iso=serializable)"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.asyncwritefailure"
title="Async Consensus Failure"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.readwithinuncertainty"
title="Read Within Uncertainty Interval"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.txnaborted"
title="Aborted"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.txnpush"
title="Push Failure"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.unknown"
title="Unknown"
nonNegativeRate
/>
</Axis>
</LineGraph>,

<LineGraph
title="KV Transaction Durations: 99th percentile"
tooltip={`The 99th percentile of transaction durations over a 1 minute period.
Expand Down
11 changes: 11 additions & 0 deletions pkg/ui/src/views/cluster/containers/nodeGraphs/dashboards/graphTooltips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,14 @@ export const StatementDenialsClusterSettingsTooltip: React.FC<{
in the format feature.statement_type.enabled = FALSE.
</div>
);

export const TransactionRestartsToolTip: React.FC<{
tooltipSelection?: string;
}> = ({ tooltipSelection }) => (
<div>
The number of transactions restarted broken down by errors{" "}
{tooltipSelection}. Refer to the transaction retry error reference{" "}
<Anchor href={docsURL.transactionRetryErrorReference}>documentation</Anchor>{" "}
for more details.
</div>
);
56 changes: 55 additions & 1 deletion pkg/ui/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ import {
} from "src/views/shared/components/metricQuery";

import { GraphDashboardProps, nodeDisplayName } from "./dashboardUtils";
import { StatementDenialsClusterSettingsTooltip } from "src/views/cluster/containers/nodeGraphs/dashboards/graphTooltips";
import {
StatementDenialsClusterSettingsTooltip,
TransactionRestartsToolTip,
} from "src/views/cluster/containers/nodeGraphs/dashboards/graphTooltips";

export default function (props: GraphDashboardProps) {
const { nodeIDs, nodesSummary, nodeSources, tooltipSelection } = props;
Expand Down Expand Up @@ -305,6 +308,57 @@ export default function (props: GraphDashboardProps) {
</Axis>
</LineGraph>,

<LineGraph
title="Transaction Restarts"
sources={nodeSources}
tooltip={
<TransactionRestartsToolTip tooltipSelection={tooltipSelection} />
}
>
<Axis label="restarts">
<Metric
name="cr.node.txn.restarts.writetooold"
title="Write Too Old"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.writetoooldmulti"
title="Write Too Old (multiple)"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.serializable"
title="Forwarded Timestamp (iso=serializable)"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.asyncwritefailure"
title="Async Consensus Failure"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.readwithinuncertainty"
title="Read Within Uncertainty Interval"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.txnaborted"
title="Aborted"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.txnpush"
title="Push Failure"
nonNegativeRate
/>
<Metric
name="cr.node.txn.restarts.unknown"
title="Unknown"
nonNegativeRate
/>
</Axis>
</LineGraph>,

<LineGraph
title="Transaction Latency: 99th percentile"
tooltip={`The 99th percentile of total transaction time over a 1 minute period.
Expand Down