release-21.1: *: check node decommissioned/draining state for DistSQL/consistency #66950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
force-pushed
the
backport21.1-66632
branch
from
36154aa to
a4795bc
Compare
ajwerner
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
DistSQL planner stuff
Reviewed 6 of 10 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
tbg
approved these changes
Jun 29, 2021
The DistSQL planner and consistency queue did not take the nodes' decommissioned or draining states into account, which in particular could cause spurious errors when interacting with decommissioned nodes. This patch adds convenience methods for checking node availability and draining states, and avoids scheduling DistSQL flows on unavailable nodes and consistency checks on unavailable/draining nodes. Release note (bug fix): Avoid interacting with decommissioned nodes during DistSQL planning and consistency checking.
erikgrinaker
force-pushed
the
backport21.1-66632
branch
from
a4795bc to
607ed27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #66632.
/cc @cockroachdb/release @cockroachdb/kv
The DistSQL planner and consistency queue did not take the nodes'
decommissioned or draining states into account, which in particular
could cause spurious errors when interacting with decommissioned nodes.
This patch adds convenience methods for checking node availability and
draining states, and avoids scheduling DistSQL flows on
unavailable nodes and consistency checks on unavailable/draining nodes.
Touches #66586, touches #45123.
Release note (bug fix): Avoid interacting with decommissioned nodes
during DistSQL planning and consistency checking.