Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvcoord: assert sanity when tracking in-flight write #66917

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

andreimatei
Copy link
Contributor

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)


pkg/kv/kvclient/kvcoord/txn_interceptor_pipeliner.go, line 564 at r1 (raw file):

				header := req.Header()
				tp.ifWrites.insert(header.Key, header.Sequence)
				// The request would better not be a ranged one, as we're only tracking

This comment seems a little off. would and are

@andreimatei andreimatei force-pushed the small.assert-no-ranged-async branch from 6da6993 to 65b0954 Compare July 1, 2021 16:22
Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)


pkg/kv/kvclient/kvcoord/txn_interceptor_pipeliner.go, line 564 at r1 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

This comment seems a little off. would and are

done

@craig
Copy link
Contributor

craig bot commented Jul 1, 2021

Build succeeded:

@craig craig bot merged commit db47a54 into cockroachdb:master Jul 1, 2021
@andreimatei andreimatei deleted the small.assert-no-ranged-async branch December 27, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants