kvserver: deadlock when getting replica.Desc while under lock #66760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error logging was using replica.Desc() to get range keys while already operating under replica read lock. It was causing deadlock if another go routine tried to acquire a write. We already have a description locally so no need to get locks at all. Release note (bug fix): Fix deadlock during adminVerifyProtectedTimestamp
|
This change is |
adityamaru
approved these changes
Jun 23, 2021
|
Ran |
tbg
approved these changes
Jun 23, 2021
|
bors r=tbg,adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error logging was using replica.Desc() to get range keys while
already operating under replica read lock. It was causing deadlock
if another go routine tried to acquire a write.
We already have a description locally so no need to get locks at
all.
Release note (bug fix): Fix deadlock during adminVerifyProtectedTimestamp
Fixes #66759