sqlsmith: fix flaky TestGenerateParse #66743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I'll update this PR to unskip |
This commit fixes the `sqlsmith.TestGenerateParse` test that has been flaking since cockroachdb#66599 when primary index stored columns were added to the output of `SHOW INDEXES`. sqlsmith uses `SHOW INDEXES` to build an in-memory representation of indexes to help generate interesting randomized queries. It is not equipped to handle `rowid` primary indexes, so rows output from `SHOW INDEXES` with a `column_name` of `rowid` are filtered out. Stored columns of primary indexes, now included in `SHOW INDEXES`, are not filtered out, causing sqlsmith to build an in-memory representation of `rowid` indexes that have only stored columns and no indexed columns. This breaks the assumption within sqlsmith that each index should have at least one indexed column, causing panics. This commit fixes the issue by removing indexes with no indexed columns from sqlsmith's in-memory index map. Fixes cockroachdb#66723 Release note: None
mgartner
force-pushed
the
66723-fix-sqlsmith-flake
branch
from
c455fba to
9a24944
Compare
Done. |
ajwerner
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
bors r=ajwerner
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @postamar)
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
sqlsmith.TestGenerateParsetest that has beenflaking since #66599 when primary index stored columns were added to the
output of
SHOW INDEXES.sqlsmith uses
SHOW INDEXESto build an in-memory representation ofindexes to help generate interesting randomized queries. It is not
equipped to handle
rowidprimary indexes, so rows output fromSHOW INDEXESwith acolumn_nameofrowidare filtered out. Storedcolumns of primary indexes, now included in
SHOW INDEXES, are notfiltered out, causing sqlsmith to build an in-memory representation of
rowidindexes that have only stored columns and no indexed columns.This breaks the assumption within sqlsmith that each index should have
at least one indexed column, causing panics.
This commit fixes the issue by removing indexes with no indexed columns
from sqlsmith's in-memory index map.
Fixes #66723
Release note: None