roachtest: scrape prometheus metrics on demand #66657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
prometheus_on_demand
branch
2 times, most recently
from
9bff031 to
07146f0
Compare
stevendanna
reviewed
Jun 21, 2021
tbg
reviewed
Jun 21, 2021
otan
force-pushed
the
prometheus_on_demand
branch
from
07146f0 to
0909766
Compare
otan
force-pushed
the
prometheus_on_demand
branch
2 times, most recently
from
c8b2973 to
bee464e
Compare
stevendanna
approved these changes
Jun 22, 2021
|
|
||
| // MakeInsecureCockroachScrapeConfig creates scrape configs for the given | ||
| // cockroach nodes. All nodes are assumed to be insecure and running on | ||
| // port 26258. |
There was a problem hiding this comment.
I believe there is a way to get the port via roachprod if this function were to take a *cluser as well. But, I think that will com naturally if we decide to follow-up with local-mode support.
There was a problem hiding this comment.
Mmm, I'll defer to that ;)
This commit adds a prometheus scraper on TPC-C workloads and scrapes their metrics. This is configured by setting it in the tpccOptions setup. It is currently set up on the multi-region chaos tests. At the end of the run, we take a snapshot of the metrics of the workload and store it as an artifact, which can be used later. Release note: None
otan
force-pushed
the
prometheus_on_demand
branch
from
bee464e to
f84cda0
Compare
|
thanks! bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a prometheus scraper on TPC-C workloads and scrapes
their metrics. This is configured by setting it in the tpccOptions
setup. It is currently set up on the multi-region chaos tests.
At the end of the run, we take a snapshot of the metrics of the workload
and store it as an artifact, which can be used later.
Release note: None