sql: add a hint for timestamptz -> string error #66454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
reviewed
Jun 14, 2021
pkg/sql/sem/tree/type_check.go
Outdated
|
|
||
| case fromFamily == types.TimestampTZFamily && toFamily == types.StringFamily: | ||
| err = errors.WithHint(err, "TIMESTAMPTZ to STRING casts depend on the current timezone; "+ | ||
| "consider using (t AT TIME ZONE 'UTC')::STRING instead.") |
There was a problem hiding this comment.
should we add
case fromFamily == types.TimestampTZFamily && toFamily == types.TimestampFamily:
too?
RaduBerinde
force-pushed
the
timestamptz-hint
branch
from
c7df879 to
07c8bcc
Compare
RaduBerinde
commented
Jun 14, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/sem/tree/type_check.go, line 515 at r1 (raw file):
Previously, otan (Oliver Tan) wrote…
should we add
case fromFamily == types.TimestampTZFamily && toFamily == types.TimestampFamily:too?
Great idea. I refactored the code a bit to make this cleaner, the hint is now stored in the cast struct.
otan
approved these changes
Jun 14, 2021
This adds hint to the error that you get if you try to cast a TIMESTAMPTZ to TIMESTAMP or STRING in a computed column expression. Release note: None
RaduBerinde
force-pushed
the
timestamptz-hint
branch
from
07c8bcc to
2defc06
Compare
|
bors r+ |
This was referenced Jun 15, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hint to the error that you get if you try to cast a
TIMESTAMPTZ to STRING in a computed column expression. It mentions a
workaround where you first convert to a timestamp using a specific
timezone.
Release note: None