server: TestTelemetrySQLStatsIndependence uses test reg server #66428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhartunian
force-pushed
the
use-test-reg-server-for-sql-stats-independence-test
branch
from
fbf00de to
81d8cc2
Compare
nkodali
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @knz)
Previously, this test hit the real registration server which caused goroutine leaks when the reg server was unavailable. The test now creates a test reg server to handle the stats calls. The test is no longer skipped. Resolves cockroachdb#63851 Release note: None
dhartunian
force-pushed
the
use-test-reg-server-for-sql-stats-independence-test
branch
from
81d8cc2 to
871b8e5
Compare
knz
approved these changes
Jun 14, 2021
|
bors r=knz,nkodali |
|
Build succeeded: |
dhartunian
deleted the
use-test-reg-server-for-sql-stats-independence-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this test hit the real registration server which caused
goroutine leaks when the reg server was unavailable.
The test now creates a test reg server to handle the stats calls.
The test is no longer skipped.
Resolves #63851
Release note: None