cloud: uncomment and fix default CPU resources in K8s configs #66065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
chrisseto
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
For those wondering n2-standard-4 has 4 CPUs and 16GB of memory, however Kubernetes/GKE reserves a chunk for itself, so 4 vcpus and 16GB of memory doesn't quite fit onto them :( These values will let the cluster run and allow room for additional services.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @taroface)
|
bors r=chrisseto |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to cockroachdb/docs#10578.
The default CPU resource limit/request was too large in the StatefulSet configs (I think I introduced this error previously). The updated value makes sense for the
n2-standard-4machines we use in our deployment tutorials, and the CPU/memory ratio is consistent with our recommendation in the Production Checklist.Also uncommented the
resourcesobject, since we recommend always defining resource requests/limits explicitly. The updated docs in cockroachdb/docs#10578 make it clear that these values should be tailored to a production deployment.cc @udnay