release-20.2: sql: fix schema privileges on descriptor read #65999
Conversation
|
This change is |
|
Note: this is quite different from #65750, I had to add a Validate for schema is called for all places where Validate for DatabaseDescriptors are called except |
Release note (bug fix): Previously a schema's privilege descriptor could become corrupted upon executing ALTER DATABASE ... CONVERT TO SCHEMA due to privileges that are invalid on a schema being copied over to the schema rendering the schema inusable due to invalid privileges.
RichardJCai
force-pushed
the
backport20.2-65750
branch
from
e90d6e0 to
0b1e366
Compare
There was a problem hiding this comment.
Out of curiosity, did we do anything about repairing the schemas for restore?
Reviewable status:
complete! 1 of 0 LGTMs obtained
I didn't add anything for restore on this one. I thought it was different from the previous case where restoring from 20.1 would cause an error in 20.2. This one is somewhat different in that it'll only be an issue if they restore a corrupted schema which will stay corrupted but then gets fixed on read I believe. I'll double check and add a restore fix if necessary. |
Backport 1/1 commits from #65750.
/cc @cockroachdb/release
Release note (bug fix): Previously a schema's privilege descriptor
could become corrupted upon executing ALTER DATABASE ...
CONVERT TO SCHEMA due to privileges that are invalid on a schema
being copied over to the schema rendering the schema inusable due
to invalid privileges.
Fixes #65697