roachtest: zip the artifacts for each test on teamcity #65831
Conversation
tbg
commented
May 28, 2021
tbg
commented
- roachtest: don't duplicate log files
- roachtest: zip the artifacts for each test on teamcity
|
This change is |
|
Nice:
|
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @tbg)
a discussion (no related file):
I think this will be a nice addition. Approved (although don't forget to remove the last commit :D). I left some comments for your consideration, but nothing blocking.
pkg/cmd/roachtest/test_runner.go, line 1274 at r2 (raw file):
defer f.Close() z := zip.NewWriter(f) rel := func(path2 string) string {
filepath.Rel calls this argument targetpath if you wanted to avoid path2
pkg/cmd/roachtest/test_runner.go, line 1303 at r2 (raw file):
return err } return os.Remove(path)
I wonder if instead of removing these files immediately, we should collect the files to delete and then delete them after we are sure we've written the zip archive? The downside is that we'll need more available disk-space, but it might prevent us from losing logs if there is some problem writing the zip file.
Since we want to have the logs for down nodes as well, roachtest copies the log directories to artifacts. It is therefore not necessary to include the logs in the `debug.zip` in addition to that. Release note: None
Often you want to download the artifacts for a specific test, but TeamCity doesn't let you do that. Zip the artifacts for each test as a workaround. TeamCity is good at navigating into zip files, so we don't lose anything in terms of poking at a test directly from TeamCity. cc @cockroachdb/test-eng Release note: None
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, stevendanna (Steven Danna) wrote…
I think this will be nice addition. Approved (although don't forget to remove the last commit :D). I left some comments for your consideration, but nothing blocking.
TFTR!
bors r=stevendanna
pkg/cmd/roachtest/test_runner.go, line 1274 at r2 (raw file):
Previously, stevendanna (Steven Danna) wrote…
filepath.Rel calls this argument
targetpathif you wanted to avoidpath2
Done.
pkg/cmd/roachtest/test_runner.go, line 1303 at r2 (raw file):
Previously, stevendanna (Steven Danna) wrote…
I wonder if instead of removing these files immediately, we should collect the files to delete and then delete them after we are sure we've written the zip archive? The downside is that we'll need more available disk-space, but it might prevent us from losing logs if there is some problem writing the zip file.
Done.
|
Build succeeded: |
