changefeedccl: Refactor errors and error wrapper event buffer. #65751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
reviewed
May 27, 2021
miretskiy
force-pushed
the
cleanup
branch
2 times, most recently
from
2687958 to
aa473d9
Compare
|
tftr |
|
Merge conflict. |
miretskiy
force-pushed
the
cleanup
branch
2 times, most recently
from
bab378e to
f132a1c
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed: |
This is a pure code move/refactoring to address comments from cockroachdb#65746: * Move errors to changefeedbase so that they are accessible. * Move error wrapper buffer to buffer.go * Unexport mem buffer. Release Notes: None
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure code move/refactoring to address comments from #65746:
Release Notes: None