Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: workload/movr: add --multi-region and --survive settings #65642

Merged
merged 3 commits into from
May 31, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented May 24, 2021

Backport 1/1 commits from #65493.

/cc @cockroachdb/release


Release note (general change): Added multi-region workloads for
cockroach demo movr --geo-partitioned-replicas. Specifying
--multi-region allows for multi-region workloads, and specifying
--survive allows for surviving AZ or REGION failures.

Release note (general change): Added multi-region workloads for
`cockroach demo movr --geo-partitioned-replicas. Specifying
`--multi-region` allows for multi-region workloads, and specifying
`--survive` allows for surviving AZ or REGION failures. Specifying
`--infer-crdb-region-column` also infers the crdb_region for
REGIONAL BY ROW tables.
@otan otan requested a review from ajstorm May 24, 2021 22:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel uncomfortable backporting this change until we have at least some testing around it. Can we address that before we proceed on backporting?

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@otan
Copy link
Contributor Author

otan commented May 25, 2021

the existing tests for these heavily flake on CI, probably because the machine is hammered. i will not have time to investigate this (we all remember what happened last time i dove into a cli issue ;P)

See also: #50970, https://github.com/cockroachdb/cockroach/blob/master/pkg/cli/interactive_tests/test_demo_partitioning.tcl.disabled.

.200706 05:17:36.196939091 EXPECT TEST: START TEST: Expect partitioning succeeds
.200706 05:18:36.743634193 EXPECT TEST: TIMEOUT WAITING FOR "movr>"

spawn /bin/bash
PS1=':''/# '
roach@7059f4574d07:~$ PS1=':''/# '
:/# 
.200706 05:17:36.196939091 EXPECT TEST: START TEST: Expect partitioning succeeds
/cockroach/cockroach demo --geo-partitioned-replicas
#
# --geo-partitioned replicas operates on a 9 node cluster.
# The cluster size has been changed from the default to 9 nodes.
#
# Welcome to the CockroachDB demo database!
#
# You are connected to a temporary, in-memory CockroachDB cluster of 9 nodes.
#
# This demo session will attempt to enable enterprise features
# by acquiring a temporary license from Cockroach Labs in the background.
# To disable this behavior, set the environment variable
# COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=true.
#
# Beginning initialization of the movr dataset, please wait...

.200706 05:18:36.743634193 EXPECT TEST: TIMEOUT WAITING FOR "movr>"
non-zero exit code: 1

@otan
Copy link
Contributor Author

otan commented May 26, 2021

let's see if #65687 deflakes partitioning, if so i have a path forward to adding the tests without flaking.

Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. I'll stay tuned. Poke again when you want me to have another look.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

otan added 2 commits May 31, 2021 09:14
This seemed to always time out in earlier runs, so give it a slightly
beefier timeout.

Release note: None
@otan otan requested a review from a team as a code owner May 30, 2021 23:14
@otan
Copy link
Contributor Author

otan commented May 30, 2021

alright, the tests are backported too

Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. :lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants