-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.1: workload/movr: add --multi-region and --survive settings #65642
release-21.1: workload/movr: add --multi-region and --survive settings #65642
Conversation
Release note (general change): Added multi-region workloads for `cockroach demo movr --geo-partitioned-replicas. Specifying `--multi-region` allows for multi-region workloads, and specifying `--survive` allows for surviving AZ or REGION failures. Specifying `--infer-crdb-region-column` also infers the crdb_region for REGIONAL BY ROW tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel uncomfortable backporting this change until we have at least some testing around it. Can we address that before we proceed on backporting?
Reviewable status: complete! 0 of 0 LGTMs obtained
the existing tests for these heavily flake on CI, probably because the machine is hammered. i will not have time to investigate this (we all remember what happened last time i dove into a cli issue ;P) See also: #50970, https://github.com/cockroachdb/cockroach/blob/master/pkg/cli/interactive_tests/test_demo_partitioning.tcl.disabled.
|
let's see if #65687 deflakes partitioning, if so i have a path forward to adding the tests without flaking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. I'll stay tuned. Poke again when you want me to have another look.
Reviewable status: complete! 0 of 0 LGTMs obtained
This seemed to always time out in earlier runs, so give it a slightly beefier timeout. Release note: None
Release note: None
alright, the tests are backported too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @otan)
Backport 1/1 commits from #65493.
/cc @cockroachdb/release
Release note (general change): Added multi-region workloads for
cockroach demo movr --geo-partitioned-replicas
. Specifying--multi-region
allows for multi-region workloads, and specifying--survive
allows for surviving AZ or REGION failures.